Skip to content

Add maxResults (Only Android) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KarlosQ wants to merge 4 commits into from
Closed

Add maxResults (Only Android) #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a848478
Update RNGeocoderModule.java
KarlosQ Dec 6, 2018
589cc87
Add maxResults (Android)
KarlosQ Dec 6, 2018
5e2fbee
Merge pull request #1 from KarlosQ/patch-2
KarlosQ Dec 6, 2018
ba1343a
Update geocoder.js
KarlosQ Dec 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions android/src/main/java/com/devfd/RNGeocoder/RNGeocoderModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,14 @@ public String getName() {
}

@ReactMethod
public void geocodeAddress(String addressName, Promise promise) {
public void geocodeAddress(String addressName, Integer maxResults, Promise promise) {
if (!geocoder.isPresent()) {
promise.reject("NOT_AVAILABLE", "Geocoder not available for this platform");
return;
}

try {
List<Address> addresses = geocoder.getFromLocationName(addressName, 2);
List<Address> addresses = geocoder.getFromLocationName(addressName, maxResults);
if(addresses != null && addresses.size() > 0) {
promise.resolve(transform(addresses));
} else {
Expand All @@ -51,14 +51,14 @@ public void geocodeAddress(String addressName, Promise promise) {
}

@ReactMethod
public void geocodePosition(ReadableMap position, Promise promise) {
public void geocodePosition(ReadableMap position, Integer maxResults, Promise promise) {
if (!geocoder.isPresent()) {
promise.reject("NOT_AVAILABLE", "Geocoder not available for this platform");
return;
}

try {
List<Address> addresses = geocoder.getFromLocation(position.getDouble("lat"), position.getDouble("lng"), 20);
List<Address> addresses = geocoder.getFromLocation(position.getDouble("lat"), position.getDouble("lng"), maxResults);
if(addresses != null && addresses.size() > 0) {
promise.resolve(transform(addresses));
} else {
Expand Down
8 changes: 4 additions & 4 deletions js/geocoder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,23 @@ export default {
this.apiKey = key;
},

geocodePosition(position) {
geocodePosition(position, maxResults = 20) {
if (!position || (!position.lat && position.lat!==0) || (!position.lng && position.lng!==0)) {
return Promise.reject(new Error("invalid position: {lat, lng} required"));
}

return RNGeocoder.geocodePosition(position).catch(err => {
return RNGeocoder.geocodePosition(position, maxResults).catch(err => {
if (!this.apiKey) { throw err; }
return GoogleApi.geocodePosition(this.apiKey, position);
});
},

geocodeAddress(address) {
geocodeAddress(address, maxResults = 2) {
if (!address) {
return Promise.reject(new Error("address is null"));
}

return RNGeocoder.geocodeAddress(address).catch(err => {
return RNGeocoder.geocodeAddress(address, maxResults).catch(err => {
if (!this.apiKey) { throw err; }
return GoogleApi.geocodeAddress(this.apiKey, address);
});
Expand Down