-
Notifications
You must be signed in to change notification settings - Fork 76
Angular 20 upgrade #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Angular 20 upgrade #132
Conversation
|
I've made sure to run
Let me know if there's anything else I should verify. Thank you :) |
| "@angular/common": "^20.3.13", | ||
| "@angular/core": "^20.3.13" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the compiled code still compatible with a 19 version? If yes - then constraint here should be widened not just bumped to 20.
eq: "@angular/common": "^19 || ^20",
Also there is no sense to narrow constraint to 20.3.13, it should work well with every 20.x version right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed it now. I tested by changing the demo app's version to 19, running tests, then smoke testing the app itself manually. It seems to work.
Although I do want to note that the peer deps before for @angular/common and @angular/core were both ^19.1.4. I've changed it to ^19.0.0 || ^20.0.0. Meaning it's even less restrictive than the previous version.
To me that seems fine. Let me know if I should revert back to the more restrictive "^19.1.4".
|
Hey @timofei-iatsenko did you get a chance to look at the changes? Let me know if there's something I should change. Thank you :) |
Closes #131
Hello 👋
This PR upgrades the angular version to 20. More about it here https://blog.angular.dev/announcing-angular-v20-b5c9c06cf301