make location optional #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for configurations without locations, allowing the envars tool to work in scenarios where location-based scoping is not needed.
- Made the
--locparameter optional in theinitcommand - Updated location validation logic to handle cases where no locations are configured
- Added conditional rendering of the
locationsfield in YAML output
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/envars/cli.py | Made --loc parameter optional; added validation to prevent using --loc when no locations configured; updated location resolution logic |
| src/envars/main.py | Updated YAML serialization to conditionally include locations field; added null-safety checks for location operations |
| tests/test_cli.py | Added tests for init and output commands without locations; added test for error when using --loc with no configured locations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for configurations without locations, allowing the envars tool to work in scenarios where location-based scoping is not needed.
in AWS we have prod, staging in Master and Sandbox
but in GCP data-platform we only have prod, staging