-
Notifications
You must be signed in to change notification settings - Fork 517
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix module registration under browserify
for reference: 850b897, 113bf9 When bundled with browserify, module was going down the "browser global" path, not the "commonjs" path. The reason was that it was looking for module as "global.module", but browserify supplies it as an argument, not a global. History digging shows that "global." was added to silence jshint warnings, so I adjusted the environment detection not to use "global.", and adjusted the jshint rules to prevent it from complaining about those lines.
- Loading branch information
1 parent
9f8e874
commit f03a94b
Showing
3 changed files
with
8 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,5 +28,6 @@ | |
"nonstandard": true, | ||
"worker": true, | ||
|
||
"-W078": true | ||
"-W078": true, | ||
"predef": ["define", "module"] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters