Skip to content
This repository was archived by the owner on Jul 11, 2024. It is now read-only.

feat: add fixer for no-typed-store rule #71

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

rafaelss95
Copy link
Collaborator

This PR aims to add a fixer suggest (it can't be a fixer as it can produce invalid code as reported in ngrx/platform#2780).

Copy link
Owner

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Just one question, can't we use fromFixture for this ?
Just asking because I really like the squiglies to spot the rules.

@rafaelss95
Copy link
Collaborator Author

👍 Just one question, can't we use fromFixture for this ?
Just asking because I really like the squiglies to spot the rules.

AFAIK we can't test suggestions using fromFixture 😞

@timdeschryver
Copy link
Owner

Eh, I thought I tried that before and it did work. But it seems like you're right... sorry 😅

@timdeschryver timdeschryver merged commit 2fecc21 into timdeschryver:master Feb 10, 2021
@github-actions
Copy link

🎉 This PR is included in version 1.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants