Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added license file and copyright notice. #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dblock
Copy link

@dblock dblock commented Feb 11, 2022

We're using this action for DCO checks and noticed the license file is missing. The package.json specifies ICS license so I just added a license file from https://choosealicense.com/licenses/isc/.

Signed-off-by: dblock [email protected]

@lukas-vlcek
Copy link

@dblock I run into this issue as well.

For my code I switched to https://github.com/tisonkun/actions-dco which has explicit license file and also does not require additional GH action to be executed first to pull PR commits. It simplifies the flow configuration a bit IMO (see Aiven-Open/prometheus-exporter-plugin-for-opensearch#210 for example).

Also the new dco action implementation seem to provide more elaborated description of how to sign-off commits (which is very helpful).

@peternied
Copy link

Thanks @lukas-vlcek. We've ended up phasing out our usage of this GitHub Action in favor of using an App https://probot.github.io/apps/dco/. Compliance wise its much easier for use to ensure apply to our whole organization.

@lukas-vlcek
Copy link

@peternied Still I can see GH action being used all over the place here: search opensearch-project org for "tim-actions/dco"

@dblock
Copy link
Author

dblock commented Aug 9, 2023

@peternied Still I can see GH action being used all over the place here: search opensearch-project org for "tim-actions/dco"

Looks like they are just dups now with the org-wide tool, and should be bulk deleted. @peternied want to followup?

@lukas-vlcek
Copy link

@peternied Perhaps https://github.com/opensearch-project/opensearch-plugin-template-java should be treated with an exception because we can not assume the GitHub App is installed in the target repository/org.

@Tim-Zhang I apology for hijacking this PR. 🙏

@peternied
Copy link

I've created a [slack thread] to continue the discussion.

@.Tim-Zhang thanks for letting us borrow this PRs' comments section for this aside.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants