*: fix builds #351
Merged
*: fix builds #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR breaks the circle dependencies between grpcio and grpcio-proto by adding a new crate named tests and examples. We can bring things back once rust-lang/cargo#6915 is fixed. The new structure also fixes a problem that crates.io denies to accept circle dependencies in dev-dependencies. More see rust-lang/cargo#4242. This PR also updates protobuf-build to the latest version.
nrc
previously approved these changes
Jul 24, 2019
proto/Cargo.toml
Outdated
| @@ -27,9 +27,10 @@ protobuf = "2" | |||
| lazy_static = { version = "1.3", optional = true } | |||
|
|
|||
| [build-dependencies] | |||
| protobuf-build = "0.7" | |||
| protobuf-build = { version = "0.8", default-features = false } | |||
| grpcio-compiler = { path = "../compiler", version = "0.5.0-alpha.2", default-features = false } | |||
| prost = { version = "0.5", optional = true } | |||
| prost-types = { version = "0.5", optional = true } | |||
| protobuf = { version = "2", optional = true } | |||
There was a problem hiding this comment.
I think all these optional build deps can be removed
overvenus
reviewed
Jul 24, 2019
tests-and-examples/src/lib.rs
Outdated
| @@ -0,0 +1 @@ | |||
|
|
|||
There was a problem hiding this comment.
Could you leave a comment about the purpose of the empty file?
overvenus
approved these changes
Jul 24, 2019
|
Should we run tests with the |
|
No, due to the difference mechanism between packages and modules, there are still things to do to support run tests against it. |
hunterlxt
approved these changes
Jul 24, 2019
|
seems that CI in Win platform met some errors. We may ignore it ? |
|
It seems tortall is down. If all the other CI passes, I think we can merge it. |
nrc
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR breaks the circle dependencies between grpcio and grpcio-proto
by adding a new crate named tests and examples. We can bring things back
once rust-lang/cargo#6915 is fixed.
The new structure also fixes a problem that crates.io denies to accept
circle dependencies in dev-dependencies. More see rust-lang/cargo#4242.
This PR also updates protobuf-build to the latest version.