Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EV-5614] Add CLUSTER_CONN_TYPE to Policy Recommendation deployment #3773

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dimitri-nicolo
Copy link
Contributor

@dimitri-nicolo dimitri-nicolo commented Feb 12, 2025

Description

  • Adds the CLUSTER_CONN_TYPE to Policy Recommendation deployment.
    • The type is either "standalone" or "management"
    • The configuration variable is used in Policy Recommendation to determine if the managed cluster watcher should be started.

See: EV-5614: https://github.com/tigera/calico-private/pull/8668

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@dimitri-nicolo dimitri-nicolo changed the title [EV-5614] Add managementclusters get watch RBAC to policyrecommendations [EV-5614] Add CLUSTER_CONN_TYPE to Policy Recommendation deployment Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants