Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing logging arguments for dikastes #3056

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

electricjesus
Copy link
Member

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

Copy link
Member

@caseydavenport caseydavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, although I'd expect UT changes to accompany this - perhaps we're missing enough coverage of this code?

@electricjesus
Copy link
Member Author

I think UTs aren't really valuable as you need to know what valid arguments are supposed to go in here first.. e.g. if dikastes changes this codebase wouldn't know what that new dikastes expects, or maybe e2e or ST-level tests are more valuable?

@electricjesus electricjesus merged commit 3f13428 into tigera:master Dec 13, 2023
@electricjesus electricjesus deleted the fixup-flags-dikastes branch December 13, 2023 10:16
@danudey danudey modified the milestones: v1.33.0, v1.34.0 Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants