Skip to content

Make default CSS easily configurable/overridable #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make default CSS easily configurable/overridable #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion styles/all/template/event/overall_header_head_append.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
<!-- IF TOPIC_SOLVED_PHPBB31 -->
<!-- INCLUDECSS @tierra_topicsolved/buttons.css -->
<!-- INCLUDECSS @tierra_topicsolved/phpbb-3-1-x.css -->
<!-- ELSE -->
<!-- INCLUDECSS @tierra_topicsolved/styles.css -->
<!-- ENDIF -->
2 changes: 1 addition & 1 deletion styles/all/template/event/viewtopic_body_post_buttons_after.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
</a>
<!-- ELSE -->
<a href="{postrow.U_SET_SOLVED}" title="{L_SET_TOPIC_NOT_SOLVED}" class="button button-icon-only">
<i class="icon fa-check fa-fw" aria-hidden="true"></i><span class="sr-only">{L_SET_TOPIC_NOT_SOLVED}</span>
<i class="icon fa-ban fa-fw" aria-hidden="true"></i><span class="sr-only">{L_SET_TOPIC_NOT_SOLVED}</span>
</a>
<!-- ENDIF -->
<!-- ELSE -->
Expand Down
2 changes: 1 addition & 1 deletion styles/all/template/event/viewtopic_topic_title_append.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
</a>
<!-- ENDIF -->
<!-- IF TOPIC_SOLVED_IMAGE -->
<a href="{{ U_SOLVED_POST }}" title="{L_TOPIC_SOLVED}">
<a class="topic_solved_title_link" href="{{ U_SOLVED_POST }}" title="{L_TOPIC_SOLVED}">
{TOPIC_SOLVED_IMAGE}
<!-- IF ! TOPIC_SOLVED_PHPBB31 -->
<span class="sr-only">{L_TOPIC_SOLVED}</span>
Expand Down
0 styles/all/theme/buttons.css → styles/all/theme/phpbb-3-1-x.css
View file
Open in desktop
File renamed without changes.
18 changes: 18 additions & 0 deletions styles/all/theme/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
.topic_solved_title_link:hover {
text-decoration: none;
}

.topic_solved_icon {
--hue: 120deg;
--sat: 100%;
--lightness: 37%;
color: hsl(var(--hue) var(--sat) var(--lightness));
}

.topic_solved_title_link .topic_solved_icon {
display: inline-flex;
}

:is(.topic_solved_title_link, .list-inner a):hover .topic_solved_icon {
color: hsl(var(--hue) var(--sat) calc(var(--lightness) - 6%));
}
12 changes: 5 additions & 7 deletions topicsolved.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,11 +304,8 @@ public function image($type, $alt = '', $url = '')
public function icon($color = '', $alt = '', $url = '')
{
$title = '';
if (empty($color))
{
$color = '00BF00';
}
$classes = 'fa fa-check-circle fa-fw';

$classes = 'topic_solved_icon fa fa-check-circle fa-fw';

/**
* This event makes it possible to customize the solved icon.
Expand All @@ -324,8 +321,9 @@ public function icon($color = '', $alt = '', $url = '')
extract($this->dispatcher->trigger_event('tierra.topicsolved.render_icon', compact($vars)));

$markup = sprintf(
'<i class="%1s" style="color: #%2s" aria-hidden="true"></i>',
$classes, $color
'<i class="%1s" style="%2s" aria-hidden="true"></i>',
$classes,
empty($color) ? '' : "color: #$color"
);

if (!empty($alt))
Expand Down