Update standalone files + standardize snapshot tests #1579
Merged
+985
−679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or()` was used. Put cnd_class on the first line to make it easy to remove it as needed.
DavisVaughan
requested changes
Oct 24, 2024
Member
DavisVaughan
left a comment
DavisVaughan
left a comment
There was a problem hiding this comment.
Thanks! A few things to tweak across the board but otherwise looks great
tests/testthat/test-unnest.R
Outdated
| test_that("unnesting column of mixed vector / data frame input is an error", { | ||
| df <- tibble(x = list(1, tibble(a = 1))) | ||
| expect_snapshot((expect_error(unnest(df, x)))) | ||
| expect_snapshot(unnest(df, x), error = TRUE, cnd_class = TRUE) |
Member
There was a problem hiding this comment.
I took a look at the updated snapshots. In all cases I believe we can drop cnd_class = TRUE.
Our advice lately is that if you really care about the error class, then you do
testthat::expect_error(class = )and if you also care about the error message, you do a separate
testthat::expect_snapshot(error = )But lately we have not been combining both features into a single snapshot
And in all cases here in tidyr I don't think we care about the error class
Member
|
Looks awesome thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usethis::use_standalone("r-lib/rlang")exect_snapshot(error = TRUE)for each errorexpect_error()inside snapshots as we no longer need the error classexpect_warning(code, regexp = NA)byexpect_no_warning()testthat::set_max_fails(Inf)for faster iteration during development