docs: enumerate the eight dir codes in facet_wrap()#6855
Open
CuiweiG wants to merge 1 commit intotidyverse:mainfrom
Open
docs: enumerate the eight dir codes in facet_wrap()#6855CuiweiG wants to merge 1 commit intotidyverse:mainfrom
dir codes in facet_wrap()#6855CuiweiG wants to merge 1 commit intotidyverse:mainfrom
Conversation
Rewrites the `dir` argument documentation to list all eight canonical two-letter codes with their starting corner and initial fill direction, following the specification teunbrand provided in the issue thread. The shorthand `"h"` and `"v"` values are retained in the code for backward compatibility but are no longer documented. Closes tidyverse#6837.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6837.
teunbrand confirmed in-thread that a docs-only change is the right resolution and provided the specification for all eight valid
dircodes. Each two-letter code is now documented with its starting corner and initial fill direction.The shorthand
"h"and"v"values are still accepted for backward compatibility but are no longer documented. A trailing paragraph separates grid shape (nrow,ncol) from fill order (dir), addressing the ambiguity hadley flagged earlier in the thread about whether a code like"tl"fills left-to-right or top-to-bottom first.Local verification: the eight documented codes were cross-checked against observed panel placement via
ggplot_build(p)$layout$layouton an 8-panel (2×4) test grid; all eight match the documented starting corner and fill direction.