Add check for threshold, warn if NA in predictors, and minor styling cleanup #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I love the idea of applicable! I'm interested in contributing, but I'll create an issue to discuss before I do much more.
In taking a peak under the hood, I saw a few areas for cleanup and tidying. This included:
I also added some error handling:
apd_pca
now aborts if threshold is not in [0, 1)score
now throws a warning if you try to usescore.apd_pca
with missing values in predictorsI did my best to break these changes up into individual commits.
Cheers!