[WEB-3916] Aligns latest pump upload with pump data #559
+259
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefers latest pump-related data over raw uploads when selecting the active pump upload Restricts attached pump settings to matching upload and time to prevent cross-dataset contamination Adds coverage to ensure fallback behavior and metadata normalization remain consistent Relates to WEB-3916
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aligns the latest pump upload selection logic with actual pump data, prioritizing pump-related datums (basal/bolus) over raw upload records when determining the active pump. It restricts pump settings to match both the selected upload and time constraints to prevent cross-dataset contamination.
Key Changes:
- New pump data-driven upload selection logic that examines basal and bolus datums to identify the most relevant upload
- Time-constrained pump settings filtering to ensure settings don't exceed the latest pump data timestamp
- Enhanced test coverage for dataset isolation, fallback scenarios, and metadata normalization
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/utils/DataUtil.js | Implements pump data-driven upload selection and time-constrained settings filtering in setLatestPumpUpload() method |
| test/utils/DataUtil.test.js | Adds comprehensive test cases for cross-dataset contamination prevention, time-based filtering, uploadId matching, and fallback behavior; updates metadata assertions to validate full settings objects |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefers latest pump-related data over raw uploads when selecting the active pump upload Restricts attached pump settings to matching upload and time to prevent cross-dataset contamination Adds coverage to ensure fallback behavior and metadata normalization remain consistent
Partnered with
exportPR: tidepool-org/export#72 for BACK-3250Relates to WEB-3916