Feature/nemo 205/architecture update

[PecaWolf]

https://tidepool.atlassian.net/browse/NEMO-205

[ArwainK]

Does this test pass? Not seeing getInstance() in TidepoolSDK?

[ArwainK]

LGTM!

Noting a few known Limitations (To Be Addressed)

• Token refresh logic not implemented
• Several data schemas incomplete (marked with TODO)
• Limited error handling - generic exceptions only
• No retry logic for network failures
• Mapping boilerplate could use code generation

[ArwainK]

This is not thread-safe with coroutines

[ArwainK]

Potential race condition here: two coroutines can both pass this check. Maybe we use a Mutex solution here? Something like:

private val requestMutex = Mutex()

override suspend fun loadNextItems() {
    if (requestMutex.isLocked || isEndReached) return
    
    requestMutex.withLock {
        if (isEndReached) return@withLock
        
        val result = onRequest(currentKey)
        // ... handle result
    }
}

[ArwainK]

Won't this stop Koin for the entire application?

Can we use Koin's scope management instead of the global instance here?

class TidepoolSDK(
    environment: Environment,
    private val tokenProvider: TokenProvider,
) {
    private val koinApp = koinApplication {
        modules(
            module {
                single<EnvironmentInternal> { environment.toInternal() }
                single<TokenProvider> { tokenProvider }
            },
            domainModule,
            dataModule,
        )
    }
    
    private val koin: Koin = koinApp.koin
    
    val confirmations: ConfirmationService by lazy { koin.get() }
    val data: DataService by lazy { koin.get() }
    val metadata: MetadataService by lazy { koin.get() }
    val users: UserService by lazy { koin.get() }
    
    fun shutdown() {
        koinApp.close()  // Only closes this instance
    }
}