Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support metric units for ski-report #2898

Conversation

CoatedMoose
Copy link
Contributor

Defaults to Fahrenheit for temperature, and inches for snowfall, but allows switching to Celsius and/or centimeters.

Additionally, add the option to hide the snowfall duration hint.

Defaults to Fahrenheit for temperature, and inches for snowfall, but
allows switching to Celsius and/or centimeters.

Additionally, add the option to hide the snowfall duration hint.
@CoatedMoose CoatedMoose requested a review from matslina as a code owner December 9, 2024 03:11
@tidbyt
Copy link

tidbyt bot commented Dec 9, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of cache.star requires review
🟡 Original Author The original author (cmorrisseau77) does not match the PR author (CoatedMoose)

@CoatedMoose
Copy link
Contributor Author

The failing check is on the duration of the run. I don't think there is anything that can be done about this. After running the profiling, the slow spot is a network call that regularly takes > 1s. (Also, if I checkout the version without my changes, the check fails with the same issue.

What can be done about this?

@CoatedMoose
Copy link
Contributor Author

Will conflict with #2886. I'll follow up and update this if the other gets merged first.

@stale stale bot added the wontfix label Jan 9, 2025
Copy link

stale bot commented Jan 11, 2025

We're automatically closing this issue because it hasn't had any activity in 30 days. If that seems like a mistake, please feel free to re-open. Thanks!

@stale stale bot closed this Jan 11, 2025
@CoatedMoose
Copy link
Contributor Author

Closing this is a mistake. Please reopen and review.

@tidbyt tidbyt locked as resolved and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant