Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove search configuration #7593

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Remove search configuration #7593

merged 3 commits into from
Feb 7, 2024

Conversation

cketti
Copy link
Member

@cketti cketti commented Feb 1, 2024

Fixes an ANR reported via Google Play.

This Binder call may be taking too long, causing the main thread to wait, and triggering the ANR
      at android.os.BinderProxy.transact (BinderProxy.java:584)
      at android.app.ISearchManager$Stub$Proxy.getSearchableInfo (ISearchManager.java:201)
      at android.app.SearchManager.getSearchableInfo (SearchManager.java:864)
      at com.fsck.k9.activity.MessageList.initializeSearchMenuItem (MessageList.kt:923)
Your app's code results in the Binder call above. Code that triggers Binder calls should be moved out of the main thread.
      at com.fsck.k9.activity.MessageList.onCreateOptionsMenu (MessageList.kt:907)

The search key now no longer opens the Search activity from anywhere in the app. Pressing the search key while the message list is displayed, will expand and focus the search view in the toolbar (can be triggered using adb shell input keyevent 84).

@cketti cketti requested a review from wmontwe as a code owner February 1, 2024 14:53
Copy link
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cketti cketti merged commit ab5f70c into main Feb 7, 2024
2 checks passed
@cketti cketti deleted the remove_searchable branch February 7, 2024 14:08
@cketti cketti mentioned this pull request Mar 25, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants