Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add finish to make sure activity closes after launching #7588

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Add finish to make sure activity closes after launching #7588

merged 1 commit into from
Jan 31, 2024

Conversation

wmontwe
Copy link
Member

@wmontwe wmontwe commented Jan 31, 2024 •
edited
Loading

Fixes #7585

I'm not a fan of having to call activity.finish() additionally. But as stated in start before finish a startActivityAndFinish() is not available.

@wmontwe wmontwe requested a review from cketti as a code owner January 31, 2024 14:24
cketti
cketti approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@cketti cketti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmontwe wmontwe merged commit 5be63ec into main Jan 31, 2024
2 checks passed
@wmontwe wmontwe deleted the fix-account-setup-finished-launcher branch January 31, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cketti cketti cketti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Finishing onboarding should finish FeatureLauncherActivity
2 participants
@wmontwe @cketti