Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use toolbar in ServerValidationScreen when editing server settings #7577

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

cketti
Copy link
Member

@cketti cketti commented Jan 26, 2024

When editing server settings of an existing account, the app is currently switching from a screen with a toolbar to a screen with AppTitleTopHeader to a screen with a toolbar. With this change, a toolbar is used in all screens displayed when editing server settings.

The setup flow is still using the AppTitleTopHeader variant.

Before After
image image

@cketti cketti requested a review from wmontwe as a code owner January 26, 2024 21:45
Copy link
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmontwe wmontwe merged commit 35a18be into main Jan 30, 2024
2 checks passed
@wmontwe wmontwe deleted the server_validation_with_toolbar branch January 30, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants