Add dependency guard #7507
Merged
Add dependency guard #7507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmontwe
force-pushed
the
add-dependency-guard
branch
from
7cd9f2e to
4f12289
Compare
wmontwe
force-pushed
the
add-dependency-guard
branch
from
f4f7860 to
54ab489
Compare
cketti
approved these changes
Jan 15, 2024
| @@ -41,6 +41,7 @@ glide = "4.16.0" | |||
| moshi = "1.15.0" | |||
| mockito = "5.8.0" | |||
| forkhandlesBom = "2.12.2.0" | |||
| pluginDependencyGuard = "0.4.3" | |||
There was a problem hiding this comment.
The other Gradle-related entries are at the top. Maybe move it there and remove the "plugin" prefix?
There was a problem hiding this comment.
The version catalog could be cleaned up, but I would do that as seperate task -> #7508
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a better control over dependencies used by the release version of the app, this introduces Dependency Guard. It creates a text file listing all dependencies in use by the
releaseRuntimeClasspathconfiguration of the K9Mail App. Whenever there is a change it will fail the build. This should help to to discover transitive dependency changes when updating project dependencies.