Add app-k9mail as top level app module
#7494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmontwe
force-pushed
the
add-top-level-app
branch
2 times, most recently
from
c964048 to
d33e756
Compare
cketti
reviewed
Jan 12, 2024
There was a problem hiding this comment.
Instead of src/debug/java this could probably be src/debug/kotlin.
There was a problem hiding this comment.
I would do that in a separate pull-request -> #7510
| @@ -0,0 +1,7 @@ | |||
| package com.fsck.k9 | |||
There was a problem hiding this comment.
We could use this opportunity to change the package name to app.k9mail.
There was a problem hiding this comment.
I would do that in a separate pull-request -> #7509
|
I tested upgrading an existing installation and all shortcuts and widgets were still working 👍 |
wmontwe
force-pushed
the
add-top-level-app
branch
from
d33e756 to
19b1129
Compare
wmontwe
force-pushed
the
add-top-level-app
branch
from
19b1129 to
daabeaa
Compare
cketti
approved these changes
Jan 15, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits the former
app:k9mailmodule into a new top level app moduleapp-k9mailto host app specific configuration and renameapp:k9mailtoapp:commonfor shared declarations.This solution is time boxed and just does the minimal changes to get it working.