Update notification preferences when fragment is created

[cketti]

Update notification preferences right away instead of waiting for it to happen in onResume().

The notification preferences were initially disabled and only enabled after the current state has been read from the NotificationChannel.

thunderbird-android/app/ui/legacy/src/main/java/com/fsck/k9/ui/settings/account/AccountSettingsFragment.kt

Lines 250 to 273 in cba9ca3

	private fun updateNotificationPreferences(account: Account) {
	notificationSettingsUpdater.updateNotificationSettings(account)
	val notificationSettings = account.notificationSettings
	notificationSoundPreference?.let { preference ->
	preference.setNotificationSound(notificationSettings.ringtone?.toUri())
	preference.isEnabled = true
	}
	notificationLightPreference?.let { preference ->
	preference.value = notificationSettings.light.name
	preference.isEnabled = true
	}
	notificationVibrationPreference?.let { preference ->
	val notificationVibration = notificationSettings.vibration
	preference.setVibration(
	isVibrationEnabled = notificationVibration.isEnabled,
	vibratePattern = notificationVibration.pattern,
	vibrationTimes = notificationVibration.repeatCount,
	)
	preference.isEnabled = true
	}
	}

However, calling updateNotificationPreferences() is skipped when the user returns from setting the notification sound.

thunderbird-android/app/ui/legacy/src/main/java/com/fsck/k9/ui/settings/account/AccountSettingsFragment.kt

Lines 102 to 111 in cba9ca3

	// Don't update the notification preferences when resuming after the user has selected a new notification sound
	// via NotificationSoundPreference. Otherwise we race the background thread and might read data from the old
	// NotificationChannel, overwriting the notification sound with the previous value.
	notificationSoundPreference?.let { notificationSoundPreference ->
	if (notificationSoundPreference.receivedActivityResultJustNow) {
	notificationSoundPreference.receivedActivityResultJustNow = false
	} else {
	maybeUpdateNotificationPreferences(account)
	}
	}

This could lead to the notification preferences never being enabled when the activity was recreated while returning from the system screen to set a notification sound (see #7468).

Fixes #7468

[rezazarchi]

I checked this pull request and tested it on my Galaxy phone and verified that the issue has been resolved. Thank you.

[wmontwe]

LGTM