Sort folders alphabetically in special folders screen #7445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmontwe
reviewed
Jan 2, 2024
| @@ -24,6 +24,10 @@ class GetSpecialFolderOptions( | |||
| ?: error("No incoming server settings available") | |||
|
|
|||
| val remoteFolders = folderFetcher.getFolders(serverSettings, authStateStorage) | |||
| .sortedWith( | |||
| compareByDescending<RemoteFolder> { it.type == FolderType.INBOX } | |||
| .thenBy(String.CASE_INSENSITIVE_ORDER) { it.displayName }, | |||
There was a problem hiding this comment.
This moves the INBOX to the first (effective third) position in the list of folders, why is that necessary?
There was a problem hiding this comment.
It's done for consistency with the existing special folder preferences under Settings → [Account] → Folders. I believe we originally did this because that's also what we do in the folder list.
We can change the sort order later. Probably best to do it when we rewrite the settings screen. Then we can also share the logic to sort the list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.