Add success onboarding screen #7427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import app.k9mail.feature.onboarding.success.R | ||
|
|
||
| @Composable | ||
| internal fun SuccessLogo( |
There was a problem hiding this comment.
Instead of writing composables inside SuccessContent, It should come under components package (used for defining reusable composables). What do you think?
wmontwe
added
the
status: needs design
wmontwe
force-pushed
the
add_success_onboarding_screen
branch
from
e391c25 to
59ba6fa
Compare
wmontwe
force-pushed
the
add_success_onboarding_screen
branch
from
59ba6fa to
2c2a731
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a functional success screen, but the design is not ideal. To match the intended look, there needs to be another design session to address some issues with the assets available in Figma.
Depends on: #7425