fix remaining signatures in v4 and v8 anm #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing all signatures to align with [my findings here](https://exphp.github.io/thpages/#anm/ins). (Note: the version of the website currently live misidentifies v7:102 as "drawRect" when it is actually "spriteRand", and mistakenly gives v8:436 an "SS" signature; the signatures in this commit are correct)
|
Note: This does break recompilation for a lot of scripts, but only because the recently-added implementation of negative script indices is wonky. (basically, adding N to signatures for v4-v7 makes them as equally broken as v8 already is) |
|
Yeah, negative script indices are something that needs to be fixed separately, because other scripts that refer to them use their real index in the file instead of the field in the script struct... Should be easy to fix, though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing all signatures to align with my findings here.
(Note: the version of the website currently live misidentifies v7:102 as "drawRect" when it is actually "spriteRand", and mistakenly gives v8:436 an "SS" signature; the signatures in this commit are correct)