-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
thecl: fix remaining r/r conflicts and warnings #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be the same as expresion calls, right?
bison 3.0 has been out for 6 years now
bison doesn't care, but it gets rid of a lot of warnings from our own calls to it.
Again, bison doesn't care about the prototype at all. This trick is even mentioned in the manual.
This breaks some things, since there is a significant difference between sub calls as expressions and sub calls as instructions. The issues range from throwing incorrect errors to generating push instructions when they shouldn't be generated. void noRet() {
nop();
}
int testRet() {
return 20;
}
void main() {
noRet(); // throws "sub used in expression can not have void return type: noRet"
int a = testRet(); // this one is fine: testRet sets the $I3 variable to 20, then $I3 is pushed to stack and assigned to a, as expected
testRet(); // this one is NOT fine, since it also pushes $I3, which is not actually used anywhere later
} Same kind of issues also happen with inline subs. This is something I mentioned here earlier. |
This reverts commit e033440. yup I was wrong, time for plan b
fixed it similarly to how i fixed instruction parameters |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes the two final r/r conflicts mentioned in #64
I don't know if sub call as instruction and sub call as expression are really equivalent, so someone please test it.
I also fixed all of the warnings gcc gave me, so now you can finally build thtk without it giving you three screenfuls of "const qualifier discarded"