thdat: fix wrong thtk_io_map() usage in th02_read() and th02_write() #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thtk_io_map() creates a read-only memory mapping, but th02_read() performs writes to the data buffer. This immediately segfaults (well actually it doesn't, because mmap always fails, but that's another story). This commit fixes it so thtk_io_pread() is used directly instead.
FOTMarut
changed the title
|
whoops, I completely forgot about this PR, and only remembered after I fixed the issue myself 😅 I'm still gonna merge this, because this is better than my solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thtk_io_map() creates a read-only memory mapping, but both th02_read() and th02_write() perform writes to the data buffer. This immediately segfaults (well actually it doesn't, because mmap always fails, but that's another story).
This commit fixes it so thtk_io_pread() is used directly instead.