Update AUTHORS

.github/.cppcheck.suppress.cfg

@@ -0,0 +1 @@
+variableScope:*

.github/workflows/ccpp.yml

@@ -17,6 +17,7 @@ jobs:
       run: ./configure
     - name: make config
       run: make config
+    - uses: ammaraskar/gcc-problem-matcher@master
     - name: make
       run: make
     - name: make install

.github/workflows/codequality.yml

@@ -0,0 +1,26 @@
+on:
+  pull_request:
+
+jobs:
+  build:
+    name: static analysis
+    runs-on: ubuntu-24.04
+    steps:
+      - name: "Check out repository"
+        uses: actions/checkout@v2
+      - name: "Prepare environment"
+        run: sudo apt-get install tcl tcl-dev openssl libssl-dev cppcheck; sudo find /usr -name EXTERNALLY-MANAGED -delete
+      - name: "configure"
+        env:
+          CC: clang
+        run: ./configure
+      - name: "make config"
+        run: make config
+      - uses: whisperity/codechecker-analysis-action@v1
+        id: codechecker
+        with:
+          build-command: "cd ${{ github.workspace }} && make eggdrop"
+      - uses: actions/upload-artifact@v4
+        with:
+          name: "CodeChecker Bug Reports"
+          path: ${{ steps.codechecker.outputs.result-html-dir }}

.github/workflows/cppcheck.yml

@@ -0,0 +1,27 @@
+name: cppcheck-annotations
+
+on:
+  pull_request:
+
+jobs:
+  build:
+    name: cppcheck-annotations
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: Run cppcheck-annotation-action
+        uses: Konstantin343/[email protected]
+        with:
+          std: 'c99'
+          platform: 'unix64'
+          log-level: 'verbose'
+          sources: 'src'
+          additional-args: '--force -DEGG_HANDLEN=15 --suppressions-list=.github/.cppcheck.suppress.cfg -DCCFLAGS=-O2'
+
+      - name: Annotate lines with errors
+        uses: yuzutech/[email protected]
+        with:
+          repo-token: "${{ secrets.GITHUB_TOKEN }}"
+          title: 'Results of CppCheck'
+          input: 'annotations.json'

AUTHORS

@@ -1,4 +1,4 @@
-Authors of Eggdrop
+ Authors of Eggdrop
 Last revised: July 27, 2010
 
 ------------------------------------------------------------------------------

Makefile.in

@@ -76,7 +76,7 @@ TCLLIB = @TCL_LIB_SPEC@
 # Extra libraries
 # XLIBS will be linked with everything
 # MODULE_XLIBS will only be linked with the module objects
-XLIBS = @SSL_LIBS@ @TCL_LIB_SPEC@ @LIBS@
+export XLIBS = @SSL_LIBS@ @TCL_LIB_SPEC@ @LIBS@
 MODULE_XLIBS = @MODULE_XLIBS@
 
 # You shouldn't need to edit anything below this line.

README

@@ -1,4 +1,4 @@
-README
+R EADME
 
   Please, at least SKIM this document before asking questions. In fact,
   READ IT if you've never successfully set up an Eggdrop bot before.

src/Makefile.in

@@ -6,6 +6,7 @@ srcdir = @srcdir@
 VPATH = @srcdir@
 
 @SET_MAKE@
+EGGEXEC = @EGGEXEC@
 INSTALL = @INSTALL@
 INSTALL_PROGRAM = @INSTALL_PROGRAM@
 INSTALL_DATA = @INSTALL_DATA@
@@ -18,6 +19,8 @@ CFLAGS = @CFLAGS@ -I.. -I$(top_srcdir) @SSL_INCLUDES@ @DEFS@ $(CFLGS)
 CPPFLAGS = @CPPFLAGS@
 LDFLAGS = @LDFLAGS@
 
+XLIBS = @SSL_LIBS@ @TCL_LIB_SPEC@ @LIBS@
+
 eggdrop_objs = bg.o botcmd.o botmsg.o botnet.o chanprog.o cmds.o dcc.o \
 dccutil.o dns.o flags.o language.o match.o main.o mem.o misc.o misc_file.o \
 modules.o net.o rfc1459.o tcl.o tcldcc.o tclhash.o tclmisc.o tcluser.o \

src/main.c

@@ -329,11 +329,11 @@
 #endif
 
 #ifdef LDFLAGS
     dprintf(-x, "Link flags: %s\n", LDFLAGS);
 #endif
 
 #ifdef STRIPFLAGS
     dprintf(-x, "Strip flags: %s\n", STRIPFLAGS);
 #endif
     dprintf(-x, "Last bind (may not be related): %s\n", last_bind_called);
     tell_dcc(-x);
@@ -978,9 +978,13 @@
   argv = arg_v;
   argv0 = argv[0];
 
+  if (1 == 0) {
+    return 0;
+  }
+
   /* Version info! */
 #ifdef EGG_PATCH
   egg_snprintf(egg_version, sizeof egg_version, "%s+%s %u", EGG_STRINGVER, EGG_PATCH, egg_numver);
   egg_snprintf(ver, sizeof ver, "eggdrop v%s+%s", EGG_STRINGVER, EGG_PATCH);
   egg_snprintf(version, sizeof version,
                "Eggdrop v%s+%s (C) 1997 Robey Pointer (C) 2010-2024 Eggheads",
@@ -1005,7 +1009,7 @@
   sv.sa_handler = got_bus;
   sigemptyset(&sv.sa_mask);
 #ifdef SA_RESETHAND
   sv.sa_flags = SA_RESETHAND;
 #else
   sv.sa_flags = 0;
 #endif
@@ -1127,7 +1131,7 @@
       unlink(pid_file);
       fp = fopen(pid_file, "w");
       if (fp != NULL) {
         fprintf(fp, "%u\n", xx);
         if (fflush(fp)) {
           /* Let the bot live since this doesn't appear to be a botchk */
           printf(EGG_NOWRITE, pid_file);

src/mod/module.h

@@ -88,8 +88,8 @@ typedef void (*chanout_butfunc)(int, int, const char *, ...) ATTRIBUTE_FORMAT(pr
 /* Redefine for module-relevance */
 
 /* 0 - 3 */
-#define nmalloc(x) (((void *(*)())global[0])((x),MODULE_NAME,__FILE__,__LINE__))
-#define nfree(x) (global[1]((x),MODULE_NAME,__FILE__,__LINE__))
+#define nmalloc(x) (((void *(*)(size_t, const char *, const char *, int))global[0])((x),MODULE_NAME,__FILE__,__LINE__))
+#define nfree(x) ((void (*)(void *, const char *, const char *, int))global[1]((x),MODULE_NAME,__FILE__,__LINE__))
 #define Context do {} while (0) /* For backward compatibility only */
 #define module_rename ((int (*)(char *, char *))global[3])
 /* 4 - 7 */
@@ -116,7 +116,7 @@ typedef void (*chanout_butfunc)(int, int, const char *, ...) ATTRIBUTE_FORMAT(pr
 #define base64_to_int ((int (*) (char *))global[20])
 #define int_to_base64 ((char * (*) (int))global[21])
 #define int_to_base10 ((char * (*) (int))global[22])
-#define simple_sprintf ((int (*)())global[23])
+#define simple_sprintf ((int (*)(char *, const char *, ...))global[23])
 /* 24 - 27 */
 #define botnet_send_zapf ((void (*)(int, char *, char *, char *))global[24])
 #define botnet_send_zapf_broad ((void (*)(int, char *, char *, char *))global[25])