Skip to content

feat: Allow deactivating polling by setting a negative polling #3205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2025

Conversation

thomaspoignant
Copy link
Owner

@thomaspoignant thomaspoignant commented Mar 13, 2025

Description

In this PR we are allowing a negative value for the config pollingInterval duration.
When you set a negative value it will deactivate the polling completely. You can always use the /admin/v1/retriever/refresh endpoint if you are using the relay-proxy or the ForceRefresh() function if you are using the go module.

Closes issue(s)

Resolve #3203

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Copy link

netlify bot commented Mar 13, 2025

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 405bb59
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/67d2aa3a15d24c00082eac01

Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.79%. Comparing base (dd1f8ab) to head (405bb59).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3205      +/-   ##
==========================================
- Coverage   85.79%   85.79%   -0.01%     
==========================================
  Files         121      121              
  Lines        5668     5666       -2     
==========================================
- Hits         4863     4861       -2     
  Misses        629      629              
  Partials      176      176              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thomaspoignant thomaspoignant marked this pull request as ready for review March 13, 2025 09:49
@kodiakhq kodiakhq bot merged commit 3b7aaf5 into main Mar 13, 2025
31 of 32 checks passed
@kodiakhq kodiakhq bot deleted the feat-3202 branch March 13, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(feature) disable PollingInterval ffclient
1 participant