Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: material difference #86

Merged

Conversation

infernosalex
Copy link
Contributor

Fix material difference

Description

Fixes #53 and I add a feature to go back to the back menu when you press key 'b'.

How Has This Been Tested?

I don't know how to test this UI feature, perhaps you could help me with some ideas.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshot from 2024-11-10 15-51-16

@thomas-mauran
Copy link
Owner

Capture d’écran, le 2024-11-11 à 17 44 33

Code seems ok I don't see the material symbol when eating a piece though neither on the black or white side.

@infernosalex
Copy link
Contributor Author

Ohhh, ok I will check on other computer to check if works or not.
And I will go a pull request after fixing (if something to fix). Anyway on my setup CTRL+'+' doesn't work change the size only of the game board not actually the history block.

@infernosalex
Copy link
Contributor Author

infernosalex commented Nov 11, 2024

Hi, I just tested and for me works perfectly. What game mode did u tried?
( now I saw if you have font bigger the piece disappears, it's what I asked, can you try with CTRL+'-')

@thomas-mauran
Copy link
Owner

Hi, I just tested and for me works perfectly. What game mode did u tried? ( now I saw if you have font bigger the piece disappears, it's what I asked, can you try with CTRL+'-')

Yes this is it, by zooming out I don't have the problem any more, maybe this can be fixed like we do for the other text on the app

@infernosalex
Copy link
Contributor Author

infernosalex commented Nov 11, 2024

Hi, I just tested and for me works perfectly. What game mode did u tried? ( now I saw if you have font bigger the piece disappears, it's what I asked, can you try with CTRL+'-')

Yes this is it, by zooming out I don't have the problem any more, maybe this can be fixed like we do for the other text on the app

Ok,I didn't find how to fix the text, like you in app, can you provide more context about it, please? Or I can just copy the ASCII from to_string function for each piece, instead using symbols?

@thomas-mauran
Copy link
Owner

Hi, I just tested and for me works perfectly. What game mode did u tried? ( now I saw if you have font bigger the piece disappears, it's what I asked, can you try with CTRL+'-')

Yes this is it, by zooming out I don't have the problem any more, maybe this can be fixed like we do for the other text on the app

Ok,I didn't find how to fix the text, like you in app, can you provide more context about it, please? Or I can just copy the ASCII from to_string function for each piece, instead using symbols?

Hello @Inf3n0s managed to get it working by setting the text to bold, for some reason this makes it stay when zooming, don't ask me why lmao.

@infernosalex
Copy link
Contributor Author

Hi, I just tested and for me works perfectly. What game mode did u tried? ( now I saw if you have font bigger the piece disappears, it's what I asked, can you try with CTRL+'-')

Yes this is it, by zooming out I don't have the problem any more, maybe this can be fixed like we do for the other text on the app

Ok,I didn't find how to fix the text, like you in app, can you provide more context about it, please? Or I can just copy the ASCII from to_string function for each piece, instead using symbols?

Hello @Inf3n0s managed to get it working by setting the text to bold, for some reason this makes it stay when zooming, don't ask me why lmao.

Awesome, so we can merge to main ?

@thomas-mauran
Copy link
Owner

thomas-mauran commented Nov 12, 2024

Yep make sure you lint the code as said in the CI: cargo fmt --check is not happy but then I can merge @Inf3n0s

@infernosalex
Copy link
Contributor Author

infernosalex commented Nov 12, 2024

Yep make sure you lint the code as said in the CI: cargo fmt --check is not happy but then I can merge @Inf3n0s

It's fixed now ig.
Thanks you @thomas-mauran ! I will come with update to implement PGN import / export probably soon...

@thomas-mauran thomas-mauran merged commit 4f2914a into thomas-mauran:main Nov 12, 2024
4 checks passed
@thomas-mauran
Copy link
Owner

Thanks again for your contribution @infernosalex

@thomas-mauran thomas-mauran self-assigned this Nov 13, 2024
@thomas-mauran thomas-mauran changed the title Fix material difference feat: material difference Nov 13, 2024
@thomas-mauran thomas-mauran added the enhancement New feature or request label Nov 13, 2024
thomas-mauran added a commit that referenced this pull request Nov 13, 2024
* Add reset the game/ go to the menu by pressing a key

* Material difference

---------

Co-authored-by: Thomas Mauran <[email protected]>
Signed-off-by: Thomas Mauran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Material difference
2 participants