-
Notifications
You must be signed in to change notification settings - Fork 534
chore: optimize onekey logo #2369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
chore: optimize onekey logo #2369
Conversation
@ByteZhang1024 is attempting to deploy a commit to the thirdweb Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe SVG icon in the codebase was updated by changing its width and height attributes from fixed pixel values to percentages, making the icon responsive to its container. No changes were made to the SVG's content or to any exported or public entities. Changes
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/injected/src/icons/onekey.ts (2)
2-2
: Preserve aspect ratio
To maintain the original proportions when scaling, consider addingpreserveAspectRatio="xMidYMid meet"
.- <svg width="100%" height="100%" viewBox="0 0 450 450" fill="none" xmlns="http://www.w3.org/2000/svg"> + <svg width="100%" height="100%" viewBox="0 0 450 450" preserveAspectRatio="xMidYMid meet" fill="none" xmlns="http://www.w3.org/2000/svg">
2-2
: Accessibility: consider ARIA attributes
If this SVG is decorative, addaria-hidden="true"
. If it conveys meaningful content, includerole="img"
and a<title>
element for screen readers.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/injected/src/icons/onekey.ts
(1 hunks)
🔇 Additional comments (2)
packages/injected/src/icons/onekey.ts (2)
2-2
: Switch to percentage-based dimensions
Changingwidth
andheight
from fixed pixels to100%
allows the SVG to scale with its container, improving responsiveness.
2-2
: Ensure parent container dimensions
Withwidth="100%" height="100%"
, the SVG’s rendered size depends entirely on its container. Verify that all usage sites define explicit container dimensions or the icon may collapse to zero size.
Description
Optimize OneKey logo style
Summary by CodeRabbit