Skip to content

Dashboard: Move In-app-wallets page #7378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Jun 19, 2025


PR-Codex overview

This PR primarily focuses on renaming and restructuring various components and routes in the application to shift from an "assets" terminology to "tokens." It also includes updates to redirect paths and adjusts the layout and functionality of several components accordingly.

Detailed summary

  • Renamed routes and components from assets to tokens.
  • Updated redirect paths for various components and pages.
  • Adjusted sidebar links to reflect new token terminology.
  • Modified function imports and exports to align with the new structure.
  • Altered UI elements to reflect changes in terminology and layout.
  • Refactored analytics and webhook components for consistency.
  • Updated types and props to accommodate the new token-focused approach.

The following files were skipped due to too many changes: apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/webhooks/page.tsx, apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/engine/cloud/server-wallets/wallet-table/wallet-table-ui.client.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel vercel bot temporarily deployed to Preview – wallet-ui June 19, 2025 12:44 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 19, 2025 12:44 Inactive
Copy link

changeset-bot bot commented Jun 19, 2025

⚠️ No Changeset found

Latest commit: 6696cac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jun 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2025 6:01pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2025 6:01pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2025 6:01pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2025 6:01pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2025 6:01pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
nebula ⬜️ Skipped (Inspect) Jun 20, 2025 6:01pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 19, 2025 12:44 Inactive
@vercel vercel bot temporarily deployed to Preview – login June 19, 2025 12:44 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula June 19, 2025 12:44 Inactive
Copy link
Contributor

coderabbitai bot commented Jun 19, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MananTank MananTank marked this pull request as ready for review June 19, 2025 12:45
@MananTank MananTank requested review from a team as code owners June 19, 2025 12:45
@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. packages labels Jun 19, 2025
Copy link
Member Author

MananTank commented Jun 19, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.35%. Comparing base (fb73366) to head (b1a5e9a).

Additional details and impacted files
@@                           Coverage Diff                            @@
##           06-19-dashboard_project_sidebar_changes    #7378   +/-   ##
========================================================================
  Coverage                                    52.35%   52.35%           
========================================================================
  Files                                          939      939           
  Lines                                        63161    63161           
  Branches                                      4217     4217           
========================================================================
  Hits                                         33070    33070           
  Misses                                       29984    29984           
  Partials                                       107      107           
Flag Coverage Δ
packages 52.35% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Jun 19, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 62.53 KB (0%) 1.3 s (0%) 3.1 s (+26.2% 🔺) 4.3 s
thirdweb (cjs) 350.55 KB (0%) 7.1 s (0%) 21.4 s (+3.94% 🔺) 28.5 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 600 ms (+197.72% 🔺) 714 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 61 ms (-25.15% 🔽) 71 ms
thirdweb/react (minimal + tree-shaking) 19.59 KB (0%) 392 ms (0%) 458 ms (+15.98% 🔺) 850 ms

@MananTank MananTank force-pushed the 06-19-dashboard_move_in-app-wallets_page_to__wallets_route branch from 7bc20b0 to 159a9d0 Compare June 20, 2025 17:46
@MananTank MananTank force-pushed the 06-19-dashboard_project_sidebar_changes branch from 37ad1df to 6113f3d Compare June 20, 2025 17:46
@vercel vercel bot temporarily deployed to Preview – nebula June 20, 2025 17:49 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 20, 2025 17:49 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 20, 2025 17:49 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 20, 2025 17:49 Inactive
@vercel vercel bot temporarily deployed to Preview – login June 20, 2025 17:49 Inactive
@MananTank MananTank merged commit c5fa3b1 into 06-19-dashboard_project_sidebar_changes Jun 20, 2025
10 of 12 checks passed
@MananTank MananTank deleted the 06-19-dashboard_move_in-app-wallets_page_to__wallets_route branch June 20, 2025 17:49
jnsdls pushed a commit that referenced this pull request Jun 21, 2025
jnsdls pushed a commit that referenced this pull request Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant