feat: Move transaction webhooks to Redis #549
Conversation
| } | ||
|
|
||
| if (resp && !resp.ok) { | ||
| if (!resp.ok) { |
There was a problem hiding this comment.
resp has type WebhookResponse | undefined. would this change cause unexpected behavior if resp is undefined?
There was a problem hiding this comment.
The default catches if resp is undefined, but I see how it can be a trap that bites us in the future.
| } | ||
|
|
||
| if (resp && !resp.ok) { | ||
| if (!resp.ok) { |
There was a problem hiding this comment.
The default catches if resp is undefined, but I see how it can be a trap that bites us in the future.
| Static<typeof transactionResponseSchema>[] | null | ||
| > => { | ||
| const tx = await prisma.transactions.findMany({ | ||
| export const getTransactionsByQueueIds = async ( |
There was a problem hiding this comment.
Simplified this to just return DB results.
| @@ -3,6 +3,9 @@ import { prisma } from "../client"; | |||
|
|
|||
| export const getAllWebhooks = async (): Promise<Webhooks[]> => { | |||
| return await prisma.webhooks.findMany({ | |||
| where: { | |||
There was a problem hiding this comment.
We never care about deleted webhooks so omit it in the query to simplify business logic.
| @@ -198,3 +200,23 @@ export enum TransactionStatus { | |||
| // Tx was cancelled and will not be re-attempted. | |||
| Cancelled = "cancelled", | |||
| } | |||
|
|
|||
| export const toTransactionSchema = ( | |||
There was a problem hiding this comment.
Maps the internal DB "transaction" to the external "transaction" schema.
| const webhooks = [ | ||
| ...(await getWebhooksByEventType(WebhooksEventTypes.ALL_TX)), | ||
| ...(await getWebhooksByEventType(data.type)), | ||
| ]; |
There was a problem hiding this comment.
Get all webhooks that match the exact type or ALL_TX which cares about all event types.
| @@ -52,7 +70,7 @@ const handler: Processor<any, void, string> = async (job: Job<string>) => { | |||
| let _worker: Worker | null = null; | |||
| if (redis) { | |||
| _worker = new Worker(SEND_WEBHOOK_QUEUE_NAME, handler, { | |||
| concurrency: 1, | |||
| concurrency: 10, | |||
There was a problem hiding this comment.
Increase concurrency now that there's more webhooks to send. Webhook calls are independent.
PR-Codex overview
This PR introduces changes related to handling webhooks and transactions. It refactors webhook handling, updates transaction schemas, and improves webhook processing efficiency.
Detailed summary