chore: support AA addresses in /send-transaction #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| chainId: chainId.toString(), | ||
| signerAddress: fromAddress, | ||
| accountAddress, | ||
| target: toAddress, |
There was a problem hiding this comment.
arent these all optional? prob dont need the if / else right? just pass everything through even if undefined
There was a problem hiding this comment.
There's some code like this:
if (tx.accountAddress && tx.signerAddress) {
// process as a userOp
}In this case accountAddress is undefined so it would be okay, but I'd like to minimize the chance any code assumes a userOp if signerAddress is set (and in this case we'd be setting signerAddress for EOA transactions too).
joaquim-verges
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the
x-account-addressheader in/backend-wallet/:chain/send-transactionPR-Codex overview
The focus of this PR is to update the wallet header schema to include an additional field
x-account-addressfor sending transactions.Detailed summary
walletHeaderSchematowalletWithAAHeaderSchemax-account-addressfield in the header for account addressaccountAddressin the header