Skip to content

Updates: Schemas, Naming, Tx Override, Packages #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 10, 2024
Merged

Conversation

farhanW3
Copy link
Contributor

@farhanW3 farhanW3 commented May 30, 2024

We had added txOverrides on end-points but it was not being passed to queueTx(), thus not getting used. So updated that now.

So got the Typings updated for NFTMetadata.attributes / NFTMetadata.properties, but:

  • Redocly says any
  • Engine SDK says any
  • Swagger UI -> Example says string (We can add an example and fix this)
  • Swagger UI -> Schema Details says ({})

Redocly
image

Engine SDK typing:
image


PR-Codex overview

This PR updates various schemas and response objects in the server codebase.

Detailed summary

  • Renamed PermissionsSchema to permissionsSchema
  • Updated response schemas in multiple routes
  • Replaced ReplySchema with responseBodySchema in route handlers

The following files were skipped due to too many changes: src/server/routes/backend-wallet/create.ts, src/server/routes/configuration/auth/get.ts, src/server/routes/configuration/cache/get.ts, src/server/routes/backend-wallet/update.ts, src/server/routes/backend-wallet/getTransactions.ts, src/server/routes/configuration/wallets/get.ts, src/server/routes/backend-wallet/withdraw.ts, src/server/routes/configuration/transactions/get.ts, src/server/routes/configuration/backend-wallet-balance/get.ts, src/server/routes/contract/extensions/accountFactory/read/isAccountDeployed.ts, src/server/routes/contract/extensions/accountFactory/read/predictAccountAddress.ts, src/server/routes/contract/extensions/account/read/getAllAdmins.ts, src/server/routes/contract/extensions/accountFactory/read/getAllAccounts.ts, src/server/routes/contract/extensions/accountFactory/read/getAssociatedAccounts.ts, src/server/routes/relayer/revoke.ts, src/server/routes/webhooks/revoke.ts, src/server/routes/relayer/index.ts, src/server/routes/backend-wallet/signMessage.ts, src/server/routes/auth/keypair/remove.ts, src/server/routes/auth/access-tokens/create.ts, src/server/routes/auth/access-tokens/revoke.ts, src/server/routes/configuration/auth/update.ts, src/server/routes/auth/permissions/revoke.ts, src/server/routes/configuration/cache/update.ts, src/server/routes/transaction/blockchain/sendSignedTx.ts, src/server/routes/backend-wallet/simulateTransaction.ts, src/server/routes/contract/extensions/erc721/read/signatureGenerate.ts, src/server/schemas/txOverrides.ts, src/server/routes/transaction/blockchain/sendSignedUserOp.ts, src/server/routes/auth/access-tokens/update.ts, src/server/schemas/nft/index.ts, src/server/routes/configuration/backend-wallet-balance/update.ts, src/server/routes/backend-wallet/signTransaction.ts, src/server/routes/contract/extensions/erc1155/read/signatureGenerate.ts, src/server/routes/backend-wallet/signTypedData.ts, src/server/routes/relayer/update.ts, src/server/routes/contract/extensions/account/read/getAllSessions.ts, src/server/routes/configuration/transactions/update.ts, src/server/routes/auth/keypair/add.ts, src/server/routes/configuration/wallets/update.ts, src/server/routes/configuration/chains/update.ts, src/server/routes/relayer/create.ts, src/server/routes/webhooks/create.ts, src/server/routes/backend-wallet/transfer.ts, src/server/routes/configuration/cors/set.ts, src/server/routes/configuration/cors/remove.ts, src/server/routes/configuration/cors/add.ts, src/server/routes/auth/permissions/grant.ts, src/server/routes/contract/write/write.ts, src/server/routes/contract/roles/write/grant.ts, src/server/routes/contract/roles/write/revoke.ts, src/server/routes/contract/extensions/erc20/write/mintBatchTo.ts, src/server/routes/contract/extensions/erc1155/write/updateTokenMetadata.ts, src/server/routes/contract/extensions/erc721/write/burn.ts, src/server/routes/contract/extensions/erc721/write/updateTokenMetadata.ts, src/server/routes/contract/extensions/erc20/write/burn.ts, src/server/routes/deploy/prebuilt.ts, src/server/routes/contract/extensions/erc721/write/lazyMint.ts, src/server/routes/contract/extensions/erc1155/write/burn.ts, src/server/routes/contract/extensions/erc721/write/transfer.ts, src/server/routes/contract/extensions/erc1155/write/lazyMint.ts, src/server/routes/contract/extensions/erc1155/write/burnBatch.ts, src/server/routes/contract/extensions/erc20/write/claimTo.ts, src/server/routes/contract/extensions/erc20/write/mintTo.ts, src/server/routes/contract/extensions/erc721/write/claimTo.ts, src/server/routes/contract/extensions/marketplaceV3/offers/write/acceptOffer.ts, src/server/routes/contract/extensions/erc1155/write/transfer.ts, src/server/routes/contract/extensions/erc20/write/transfer.ts, src/server/routes/contract/extensions/erc1155/write/airdrop.ts, src/server/routes/contract/extensions/erc721/write/mintTo.ts, src/server/routes/contract/extensions/erc20/write/burnFrom.ts, src/server/routes/contract/extensions/erc1155/write/claimTo.ts, src/server/routes/contract/extensions/erc721/write/transferFrom.ts, src/server/routes/contract/extensions/marketplaceV3/offers/write/cancelOffer.ts, src/server/routes/contract/extensions/erc20/write/updateClaimConditions.ts, src/server/routes/contract/extensions/erc20/write/setAllowance.ts, src/server/routes/contract/extensions/erc721/write/updateClaimConditions.ts, src/server/routes/contract/extensions/erc1155/write/transferFrom.ts, src/server/routes/contract/extensions/erc1155/write/mintTo.ts, src/server/routes/contract/extensions/erc721/write/mintBatchTo.ts, src/server/routes/contract/extensions/erc20/write/transferFrom.ts, src/server/routes/contract/extensions/erc20/write/signatureMint.ts, src/server/routes/contract/extensions/erc721/write/setApprovalForAll.ts, src/server/routes/contract/extensions/erc721/write/setApprovalForToken.ts, src/server/routes/contract/extensions/erc1155/write/updateClaimConditions.ts, src/server/routes/contract/extensions/erc721/write/signatureMint.ts, src/server/routes/contract/royalties/write/setTokenRoyaltyInfo.ts, src/server/routes/contract/extensions/erc1155/write/setApprovalForAll.ts, src/server/routes/contract/extensions/erc1155/write/signatureMint.ts, src/server/routes/contract/extensions/erc1155/write/mintBatchTo.ts, src/server/routes/deploy/prebuilts/pack.ts, src/server/routes/deploy/prebuilts/vote.ts, src/server/routes/contract/extensions/erc1155/write/setBatchClaimConditions.ts, src/server/routes/deploy/prebuilts/split.ts, src/server/routes/deploy/prebuilts/token.ts, src/server/routes/contract/extensions/marketplaceV3/directListings/write/approveBuyerForReservedListing.ts, src/server/routes/contract/extensions/marketplaceV3/directListings/write/buyFromListing.ts, src/server/routes/deploy/prebuilts/nftDrop.ts, src/server/routes/deploy/prebuilts/edition.ts, src/server/routes/contract/extensions/marketplaceV3/directListings/write/cancelListing.ts, src/server/routes/contract/extensions/erc1155/write/mintAdditionalSupplyTo.ts, src/server/routes/deploy/prebuilts/multiwrap.ts, src/server/routes/deploy/prebuilts/tokenDrop.ts, src/server/routes/contract/extensions/erc20/write/setClaimConditions.ts, src/server/routes/contract/extensions/erc721/write/setClaimConditions.ts, src/server/routes/deploy/prebuilts/editionDrop.ts, src/server/routes/contract/extensions/erc1155/write/setClaimConditions.ts, src/server/routes/contract/extensions/marketplaceV3/directListings/write/revokeBuyerApprovalForReservedListing.ts, src/server/routes/deploy/prebuilts/marketplaceV3.ts, src/server/routes/deploy/prebuilts/nftCollection.ts, src/server/routes/deploy/prebuilts/signatureDrop.ts, src/server/routes/contract/extensions/marketplaceV3/directListings/write/revokeCurrencyApprovalForListing.ts, src/server/routes/contract/extensions/marketplaceV3/offers/write/makeOffer.ts, src/server/routes/contract/extensions/marketplaceV3/directListings/write/updateListing.ts, src/server/routes/backend-wallet/sendTransactionBatch.ts, src/server/routes/contract/extensions/marketplaceV3/directListings/write/createListing.ts, src/server/routes/contract/royalties/write/setDefaultRoyaltyInfo.ts, src/server/routes/contract/extensions/account/write/revokeSession.ts, src/server/routes/deploy/published.ts, src/server/routes/contract/extensions/account/write/grantAdmin.ts, src/server/routes/contract/extensions/account/write/revokeAdmin.ts, src/server/routes/contract/extensions/accountFactory/write/createAccount.ts, src/server/routes/contract/extensions/account/write/updateSession.ts, src/server/routes/contract/extensions/account/write/grantSession.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@farhanW3 farhanW3 requested a review from arcoraven May 30, 2024 01:18
@farhanW3 farhanW3 marked this pull request as ready for review May 30, 2024 01:42
@farhanW3 farhanW3 changed the title Updates: Schemas, Casing, Tx Override Updates: Schemas, Naming, Tx Override, Packages May 30, 2024
@farhanW3 farhanW3 changed the title Updates: Schemas, Naming, Tx Override, Packages [WIP]: Updates: Schemas, Naming, Tx Override, Packages May 30, 2024
@farhanW3 farhanW3 changed the title [WIP]: Updates: Schemas, Naming, Tx Override, Packages Updates: Schemas, Naming, Tx Override, Packages Jun 10, 2024
@farhanW3 farhanW3 merged commit 4ef3b08 into main Jun 10, 2024
3 checks passed
@farhanW3 farhanW3 deleted the fk/engine-updates branch June 10, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants