Skip to content

Add auction winner check in collectAuctionTokens in EnglishAuctionsLogic.sol #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add auction winner check in collectAuctionTokens in EnglishAuctionsLogic.sol #591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c69f683
add auction winner check in collectAuctionTokens
goldnite Dec 14, 2023
10e79d0
Merge branch 'main' into main
goldnite Jan 4, 2024
5abc5f2
Merge branch 'main' into main
goldnite Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/prebuilts/marketplace/english-auctions/EnglishAuctionsLogic.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ contract EnglishAuctionsLogic is IEnglishAuctions, ReentrancyGuard, ERC2771Conte

require(_targetAuction.status != IEnglishAuctions.Status.CANCELLED, "Marketplace: invalid auction.");
require(_targetAuction.endTimestamp <= block.timestamp, "Marketplace: auction still active.");
require(_winningBid.bidder != address(0), "Marketplace: no bids were made.");
require(_winningBid.bidder == _msgSender(), "Marketplace: not auction winner.");

_closeAuctionForAuctionCreator(_targetAuction, _winningBid);

Expand Down
2 changes: 1 addition & 1 deletion contracts/prebuilts/marketplace/marketplace-v3.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,7 @@ The `EnglishAuctions` extension smart contract lets you sell NFTs (ERC-721 or ER
| auctionId | The unique ID of the auction to collect the payout for. |
- Criteria that must be satisfied
- The auction must be expired.
- The caller must be the winning bidder.
- The caller must be the auction winner.

### `bidInAuction`

Expand Down