Skip to content

Add pytest #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Add pytest #17

wants to merge 28 commits into from

Conversation

cjber
Copy link
Contributor

@cjber cjber commented Mar 26, 2025

Adds pytest for insight and engine tests using thirdweb-dev api. Should I be using a dummy API instead? I wanted to ensure the API calls work correctly e.g. when we are messing around with types.

Also adds tests for adapters

@cjber cjber requested a review from jakeloo March 28, 2025 11:15
@cjber cjber marked this pull request as ready for review March 31, 2025 13:13
@cjber
Copy link
Contributor Author

cjber commented Mar 31, 2025

Ref NEB-132

Copy link
Member

@jakeloo jakeloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add CI step to run test automatically?

@cjber
Copy link
Contributor Author

cjber commented Apr 1, 2025

Added - we just need a way of using the dev private key

@cjber
Copy link
Contributor Author

cjber commented Apr 2, 2025

Need you to add the secret defined in the CI for it to run. I can't access repo settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants