[IMP] edi_storage_oca: Allow files with duplicate names to create Edi Exchange Record #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thienvh332
force-pushed
the
12.0-imp-edi_storage_oca
branch
from
dfd6171 to
8c5eb48
Compare
| @@ -10,6 +10,10 @@ | |||
| <field name="storage_id" /> | |||
| <field name="input_dir_pending" /> | |||
| <field name="input_dir_remove" /> | |||
| <field | |||
| name="input_allow_duplicate_filename" | |||
| attrs="{'invisible': [('input_dir_remove', '=', False)]}" | |||
There was a problem hiding this comment.
Suggested change
| attrs="{'invisible': [('input_dir_remove', '=', False)]}" |
| @@ -58,6 +58,8 @@ class EDIBackend(models.Model): | |||
| output_dir_error = fields.Char( | |||
| "Output error directory", help="Path to folder for error operations" | |||
| ) | |||
| input_allow_duplicate_filename = fields.Boolean( | |||
| help="Allow files with duplicate names to create Edi Exchange Record") | |||
There was a problem hiding this comment.
Suggested change
| help="Allow files with duplicate names to create Edi Exchange Record") | |
| help="For this backend, filenames are not unique, e.g. output.edi") |
thienvh332
force-pushed
the
12.0-imp-edi_storage_oca
branch
from
8c5eb48 to
52bf140
Compare
| @@ -23,4 +24,4 @@ | |||
| </notebook> | |||
| </field> | |||
| </record> | |||
| </odoo> | |||
| </odoo> | |||
nilshamerlinck
approved these changes
Feb 10, 2025
thienvh332
force-pushed
the
12.0-imp-edi_storage_oca
branch
from
52bf140 to
8f7b612
Compare
thienvh332
force-pushed
the
12.0-imp-edi_storage_oca
branch
from
8f7b612 to
16257eb
Compare
|
didn't make it to the oca side? |
Hi sir, Should I create a new PR for this? (Although they don't seem to care) |
|
yes please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.