edi_sale_ubl: fix tests, handle increased qty

edi_sale_ubl_oca/models/sale_order.py

@@ -106,9 +106,10 @@ def _edi_get_line_state_code(self, vals_by_edi_id):
         if not vals:
             # Brand new line
             return self.order_id.EDI_STATE_ORDER_LINE_ADDED
-        if not self.product_uom_qty:
+        qty = self.product_uom_qty
+        if not qty:
             return self.order_id.EDI_STATE_ORDER_LINE_NOT_ACCEPTED
-        if self.product_uom_qty < vals["product_uom_qty"]:
+        if qty > vals["product_uom_qty"] or qty < vals["product_uom_qty"]:
             return self.order_id.EDI_STATE_ORDER_LINE_CHANGED
         if self.product_id.id != vals["product_id"]:
             return self.order_id.EDI_STATE_ORDER_LINE_CHANGED

edi_sale_ubl_oca/tests/test_order_state.py

@@ -48,8 +48,8 @@ def test_state_partially_accepted(self):
         self.assertEqual(
             order.edi_state_id.code, order.EDI_STATE_ORDER_CONDITIONALLY_ACCEPTED
         )
-        self.assertTrue(
-            order.mapped("order_line.edi_state_id.code"),
+        self.assertEqual(
+            [x.edi_state_id.code for x in order.order_line],
             [
                 order.EDI_STATE_ORDER_LINE_CHANGED,
                 order.EDI_STATE_ORDER_LINE_ACCEPTED,
@@ -61,8 +61,8 @@ def test_state_partially_accepted(self):
         self.assertEqual(
             order.edi_state_id.code, order.EDI_STATE_ORDER_CONDITIONALLY_ACCEPTED
         )
-        self.assertTrue(
-            order.mapped("order_line.edi_state_id.code"),
+        self.assertEqual(
+            [x.edi_state_id.code for x in order.order_line],
             [
                 order.EDI_STATE_ORDER_LINE_CHANGED,
                 order.EDI_STATE_ORDER_LINE_CHANGED,
@@ -74,8 +74,8 @@ def test_state_partially_accepted(self):
         self.assertEqual(
             order.edi_state_id.code, order.EDI_STATE_ORDER_CONDITIONALLY_ACCEPTED
         )
-        self.assertTrue(
-            order.mapped("order_line.edi_state_id.code"),
+        self.assertEqual(
+            [x.edi_state_id.code for x in order.order_line],
             [
                 order.EDI_STATE_ORDER_LINE_CHANGED,
                 order.EDI_STATE_ORDER_LINE_CHANGED,
@@ -87,21 +87,34 @@ def test_state_partially_accepted(self):
         self.assertEqual(
             order.edi_state_id.code, order.EDI_STATE_ORDER_CONDITIONALLY_ACCEPTED
         )
-        self.assertTrue(
-            order.mapped("order_line.edi_state_id.code"),
+        self.assertEqual(
+            [x.edi_state_id.code for x in order.order_line],
             [
                 order.EDI_STATE_ORDER_LINE_ACCEPTED,
                 order.EDI_STATE_ORDER_LINE_CHANGED,
                 order.EDI_STATE_ORDER_LINE_CHANGED,
             ],
         )
+        # get more qty for line 1
+        line1.product_uom_qty = orig_qties[line1.id] + 1
+        self.assertEqual(
+            order.edi_state_id.code, order.EDI_STATE_ORDER_CONDITIONALLY_ACCEPTED
+        )
+        self.assertEqual(
+            [x.edi_state_id.code for x in order.order_line],
+            [
+                order.EDI_STATE_ORDER_LINE_CHANGED,
+                order.EDI_STATE_ORDER_LINE_CHANGED,
+                order.EDI_STATE_ORDER_LINE_CHANGED,
+            ],
+        )
         # discard line 1
         line1.product_uom_qty = 0
         self.assertEqual(
             order.edi_state_id.code, order.EDI_STATE_ORDER_CONDITIONALLY_ACCEPTED
         )
-        self.assertTrue(
-            order.mapped("order_line.edi_state_id.code"),
+        self.assertEqual(
+            [x.edi_state_id.code for x in order.order_line],
             [
                 order.EDI_STATE_ORDER_LINE_NOT_ACCEPTED,
                 order.EDI_STATE_ORDER_LINE_CHANGED,