Remove path for the ipset executable to make it work on non-redhat based distribution #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 19, 2014 11:43
|
I had no idea anyone was using this hack of a module :-) Your change for the path looks good, but the other where you remove the '.+' doesn't : Changing from ' .+ ' to plain ' ' will break. Changing from ' .+ ' to ' .*' probably wouldn't, but it would be less restrictive than the initial regexp. Can you show me some of the lines that didn't match properly for you? |
add logoutput to false for ipset list command
fix(puppet) puppet6 needs this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On ubuntu based system, ipset is located in /sbin instead of /usr/sbin.