Removed tab-index from non-target Gap Fill texts #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One could argue that also the *non-target texts* should have a tab-index, but I think its better to go from the *answer target* straight to the next *answer target* or the *next button*. In other words; I don't see why Introtext, Text surrounding targets and Feedback should have a tab-index. This changes: - Defines `tabIndex = 0` instead of `tabIndex = 1` because I remove the *Introductory Text* tab-index. - Removes the tab-indexes from the *text* surrounding the *target*. - Removes all *FeedbackTxt* tab-indexes. - Removes the `tabindex="1"` from `mainText` to remove the *Introductory Text* tab-index.
|
@JdenHartog THis one needs some checking with someone who has access to a person using a screenreader. Ill ask Alistair for some guidance on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One could argue that also the non-target texts should have a tab-index, but I think its better to go from one answer target straight to the next answer target or the next button. In other words; I don't see why Introtext, Text surrounding targets and Feedback should have a tab-index. This changes:
tabIndex = 0instead oftabIndex = 1because I remove the Introductory Text tab-index.tabindex="1"frommainTextto remove the Introductory Text tab-index.