Skip to content

module_adapter: validate channels and cadence tlv #10902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abonislawski wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −0
Open

module_adapter: validate channels and cadence tlv #10902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7b9dbe
audio: module_adapter: bound host channels_count at ipc4 init
abonislawski Jun 12, 2026
3761e83
audio: cadence: validate TLV param size before applying config
abonislawski Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/audio/module_adapter/module/cadence.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,16 @@ int cadence_codec_apply_params(struct processing_module *mod, int size, void *da
*/
while (size > 0) {
param = data;

/* Host-supplied blob: bound param->size before dereferencing. */
if (size < (int)sizeof(*param) ||
param->size <= sizeof(*param) ||
param->size > (uint32_t)size) {
comp_err(dev, "invalid param size %u, %d bytes left",
param->size, size);
return -EINVAL;
}
Comment thread
abonislawski marked this conversation as resolved.

comp_dbg(dev, "cadence_codec_apply_config() applying param %d value %d",
param->id, param->data[0]);

Expand Down
8 changes: 8 additions & 0 deletions src/audio/module_adapter/module_adapter_ipc4.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,14 @@ int module_adapter_init_data(struct comp_dev *dev,
dst->base_cfg = cfg->base_cfg;
dst->size = cfgsz;

/* Host-supplied channel count indexes PLATFORM_MAX_CHANNELS arrays. */
if (dst->base_cfg.audio_fmt.channels_count == 0 ||
dst->base_cfg.audio_fmt.channels_count > PLATFORM_MAX_CHANNELS) {
comp_err(dev, "invalid channels count %u",
dst->base_cfg.audio_fmt.channels_count);
return -EINVAL;
}

if (cfgsz >= sizeof(*cfg)) {
int n_in = cfg->base_cfg_ext.nb_input_pins;
int n_out = cfg->base_cfg_ext.nb_output_pins;
Expand Down
Loading