app: boards: imx95: Disable edma1 node#10900
Open
dbaluta wants to merge 1 commit into
Open
Conversation
dbaluta
requested review from
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Disables the EDMA1 device-tree node for the i.MX95 EVK M7 DDR overlay to prevent Zephyr’s dma_mcux_edma.c driver from being selected (and failing to compile due to cache configuration constraints) when SOF inherits the board configuration.
Changes:
- Adds an override for
&edma1intended to disable the node so it won’t selectDMA_MCUX_EDMA.
dbaluta
force-pushed
the
disable_edma1
branch
2 times, most recently
from
64a3980 to
b16db68
Compare
Zephyr commit 58e859c5dd37b88 ("boards: nxp: imx95_evk: enable EDMA1 for
M7 core") enables EDMA1 node which in turn enables dma_mcux_edma.c
driver.
dma_mcux_edma.c requires some attention w.r.t cache configuration
options.
SOF doesnt use EDMA1 nodes but inherits edma1 node which selects
DMA_MCUX_EDMA and causes the following compilation errors:
dma_mcux_edma.c:1225:2: error: #error Unexpected or disallowed
cache situation for dma descriptors
So disable edma1 node as we don't use it.
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
tmleman
approved these changes
Jun 12, 2026
lgirdwood
approved these changes
Jun 12, 2026
Contributor
|
@dbaluta is this expected?:https://github.com/thesofproject/sof/actions/runs/27417218980/job/81034372215?pr=10900 -- Found devicetree overlay: /__w/sof/sof/sof/app/boards/imx95_evk_mimx9596_m7_ddr.overlay
devicetree error: /__w/sof/sof/sof/app/boards/imx95_evk_mimx9596_m7_ddr.overlay:29 (column 1): parse error: undefined node label 'edma1'
CMake Error at /__w/sof/sof/zephyr/cmake/modules/dts.cmake:324 (execute_process):
execute_process failed command indexes:
1: "Child return code: 1"
Call Stack (most recent call first):
/__w/sof/sof/zephyr/cmake/modules/dts.cmake:438 (dts_edt_pickle)
/__w/sof/sof/zephyr/cmake/modules/zephyr_default.cmake:133 (dts_init)
/__w/sof/sof/zephyr/cmake/modules/zephyr_default.cmake:133 (cmake_language)
/__w/sof/sof/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:66 (include)
/__w/sof/sof/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:92 (include_boilerplate)
CMakeLists.txt:5 (find_package) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zephyr commit 58e859c5dd37b88 ("boards: nxp: imx95_evk: enable EDMA1 for M7 core") enables EDMA1 node which in turn enables dma_mcux_edma.c driver.
dma_mcux_edma.c requires some attention w.r.t cache configuration options.
SOF doesnt use EDMA1 nodes but inherits edma1 node which selects DMA_MCUX_EDMA and causes the following compilation errors:
dma_mcux_edma.c:1225:2: error: #error Unexpected or disallowed cache situation for dma descriptors
So disable edma1 node as we don't use it.