up_down_mixer: reject unsupported channel configurations#10890
Merged
Conversation
init_mix() left mix_routine NULL for combos unhandled by select_mix_out_*() but accepted by set_downmix_coefficients() add NULL-check before calling set_downmix_coefficients() Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents the up/down mixer from accepting unsupported input/output channel configurations by rejecting cases where select_mix_out_*() fails to choose a mixing routine, avoiding later NULL function-pointer use.
Changes:
- Add an
init_mix()guard that rejects configurations whencd->mix_routineisNULL. - Emit an error log and return
-EINVALfor unsupported channel configurations.
abonislawski
force-pushed
the
fix/upd-mix-check
branch
from
10b7a9a to
ffd3cd2
Compare
kv2019i
approved these changes
Jun 12, 2026
lgirdwood
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
init_mix() left mix_routine NULL for combos unhandled by select_mix_out_*() but accepted by set_downmix_coefficients()
add NULL-check before calling set_downmix_coefficients()