Repository navigation
Conversation
This reverts commit 8e069e3. Conflicts with the already upstream UAOL BE id definitons. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
ujfalusi
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
plbossart and
ranj063
as code owners
November 11, 2026 13:35
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the HDMI input DAI link revert.
No open issues 🎉
What changed in this PR
Reverts HDMI input DAI link support in the generic Skylake HDA DSP machine driver to avoid the reported conflict with upstream UAOL backend IDs.
Changes:
- Removes the
HDMI_IN_BE_IDdefinition. - Replaces the HDMI input link-order entry with
SOF_LINK_NONEand its corresponding ID with0.
| File | Description |
|---|---|
sound/soc/intel/boards/skl_hda_dsp_generic.c |
Removes HDMI input from the configured backend link order and IDs. |
Review effort: Balanced
bardliao
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 8e069e3.
Conflicts with the already upstream UAOL BE id definitons.