Repository navigation
fix: preserve a leading BOM when set_key and unset_key rewrite a file - #755
Open
MohammedAlkindi wants to merge 4 commits into
Open
MohammedAlkindi wants to merge 4 commits into
MohammedAlkindi wants to merge 4 commits into
Conversation
The parser strips a leading UTF-8 BOM so the first variable is read correctly, but the stripped BOM never reaches the bindings that set_key and unset_key write back out. Rewriting a file that had one therefore dropped it silently, changing a part of the file the caller did not ask to touch. Carry it across in rewrite(), which both writers share.
…-rewrite # Conflicts: # CHANGELOG.md
…-rewrite # Conflicts: # CHANGELOG.md
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopens #687, which closed when I deleted my fork by mistake. The commits are unchanged.
set_key and unset_key dropped a leading UTF-8 BOM. #640 stripped it for parsing, but the bindings never received it, so the rewrite lost it. rewrite() now keeps the BOM, and only files that already had one change. The new tests fail on main and pass here, and the full suite passes.