Skip to content

feat: add retry function for dynamodb putItem in addEvents #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add retry function for dynamodb putItem in addEvents #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,8 @@ var es = require('eventstore')({
useUndispatchedEventsTable: true // optional
eventsTableStreamEnabled: false // optional
eventsTableStreamViewType: 'NEW_IMAGE', // optional
emitStoreEvents: true // optional, by default no store events are emitted
emitStoreEvents: true, // optional, by default no store events are emitted
maxAddEventsRetryCount: 0 // optional, number. retry times if putItem failed. 0 means do not retry
});
```

Expand Down
44 changes: 41 additions & 3 deletions lib/databases/dynamodb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ function DynamoDB(options) {
SnapshotWriteCapacityUnits: 1,
useUndispatchedEventsTable: true,
eventsTableStreamEnabled: false,
eventsTableStreamViewType: "NEW_IMAGE"
eventsTableStreamViewType: "NEW_IMAGE",
maxAddEventsRetryCount: 0
};

this.options = _.defaults(this.options, defaults);
Expand Down Expand Up @@ -182,15 +183,52 @@ _.extend(DynamoDB.prototype, {
};

debug("Saving event to events table: " + JSON.stringify(storedEvent, null, 2));
self.documentClient.put(storedEvent, function (err, data) {
function saveEvent (cb) {
self.documentClient.put(storedEvent, cb);
}

function savedCallback (err, data) {
if (err) {
error("dynamodb.addEvents error: " + JSON.stringify(err));
return callback(err);
} else {
debug("event saved");
callback(null, data);
}
});
}

function retrySaveEvent () {
var maxAddEventsRetryCount = self.options.maxAddEventsRetryCount;

if (!maxAddEventsRetryCount) {
saveEvent(savedCallback);
return;
}

var retryCount = retryCount || 0;

function _retry() {
saveEvent(function(err, data) {
if (!err) {
savedCallback(null, data);
} else {
if (retryCount === maxAddEventsRetryCount) {
error("retry failed: " + retryCount + " times");
savedCallback(err, data);
} else {
debug("dynamodb.addEvents error: " + JSON.stringify(err) + " . Retry...");
retryCount++;
var delay = 50 * Math.pow(2, retryCount - 1);
setTimeout(_retry, delay);
}
}
});
}

_retry();
}

retrySaveEvent();
}];

if (self.options.useUndispatchedEventsTable) {
Expand Down