-
Notifications
You must be signed in to change notification settings - Fork 82
✨ Device managemnet in account settings #2340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
b-l-i-n-d
wants to merge
9
commits into
4.0.0-dev
Choose a base branch
from
v4-devices
base: 4.0.0-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+171
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… update icon enums in TypeScript and PHP.
Added REMOVE_DEVICE_MANUALLY and REMOVE_ALL_ACTIVE_LOGINS to the endpoints object to support manual device removal and clearing all active logins.
Introduces new button variants: ghost-brand, link-gray, and link-destructive, updating SCSS mixins and tokens to support their styles and icon colors. Updates theme variables for critical hover states, adds the new variants to the Variant constants, and demonstrates them in the button component demo.
Introduces a new property and setter method to allow setting HTML content for the confirmation message in ConfirmationModal. Falls back to plain text if HTML is not provided, enhancing flexibility for modal content.
shewa12
approved these changes
Jan 29, 2026
harunollyo
requested changes
Jan 29, 2026
components/ConfirmationModal.php
Outdated
| * | ||
| * @return $this | ||
| */ | ||
| public function message_html( string $html ) { |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of writing another method. Add support to message method to allow specific HTML tags.
$this->allowed_message_tags = array(
'strong' => array()
);| $icon_html, | ||
| esc_html( $this->title ?? __( 'Are you sure?', 'tutor' ) ), | ||
| esc_html( $this->message ?? __( 'Are you sure you want to perform this action? Please confirm your choice.', 'tutor' ) ), | ||
| $message_html, |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wp_kses( $this->message, $this->allowed_message_tags );…sage_html` with `allowed_html_tags` for `wp_kses` sanitization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.