More flexible file logging channel options #270
+32
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Nov 27, 2024
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
It took me a while to figure out exactly what it was doing, so I've modified the PR title to better cover it. Please modify it if you disagree.
Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
Contributor
Author
|
Thanks for the review. The new title works for me and is a better description. I've accepted your suggestions and re-run the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-269
I've made the decision not to allow users to specify a file_versions without a size. This configuration which will have no affect as the file will not rotate until it hits the file_size which by default is unlimited.
Unit tests passing.
Fixes #269