Open
Conversation
This uses the mock configs from the host to reduce duplication. It also uses modularity in EL8 rather than using a flattened layout. Additionally an EL9 mock config is created. (cherry picked from commit c70b84a)
Merged
ehelms
reviewed
Sep 28, 2022
mock/el8.cfg
Outdated
| baseurl=http://koji.katello.org/kojifiles/releases/split/yum/koji-modules/koji/staged/x86_64/RHEL-8-001-mod/python38:3.8/ | ||
| module_hotfixes=1 | ||
| config_opts['root'] = 'pulpcore-el8-x86_64' | ||
| config_opts['chroot_setup_cmd'] += " python38-rpm-macros" |
Member
There was a problem hiding this comment.
Suggested change
| config_opts['chroot_setup_cmd'] += " python38-rpm-macros" | |
| config_opts['chroot_setup_cmd'] += " python39-rpm-macros" |
Member
Author
There was a problem hiding this comment.
I copied it from 3.18. Was 3.18 still Python 3.8 or was that already 3.9?
ehelms
reviewed
Sep 28, 2022
mock/el7.cfg
Outdated
| @@ -0,0 +1,15 @@ | |||
| include('centos-7-x86_64.cfg') | |||
Member
There was a problem hiding this comment.
I think this can be dropped for 3.21 as only EL8 and EL9 are build targets.
ekohl
force-pushed
the
rpm/3.21-update-mock
branch
from
420f977 to
be7023a
Compare
ehelms
approved these changes
Sep 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the mock configs from the host to reduce duplication. It also uses modularity in EL8 rather than using a flattened layout.
Additionally an EL9 mock config is created.
Besides the cherry pick of c70b84a this also updates the configs to point to 3.21.